Merged
Conversation
This commit introduces a new configuration option `validate_sending_time` to `ExFix.SessionConfig`. When set to `false`, the validation of the SendingTime (tag 52) field in incoming messages will be skipped. This provides flexibility for scenarios where SendingTime accuracy is not critical or is handled by other systems, potentially improving message processing performance. The following changes were made: - Added `validate_sending_time` (boolean, default: true) to `ExFix.SessionConfig`. - Modified `ExFix.Session.validate_sending_time/5` to respect this new config. - Updated `ExFix.Parser.parse1/5` and `ExFix.Parser.parse/5` to accept and pass down the `validate_sending_time` parameter. - Adjusted `ExFix.Session.handle_incoming_data/2` to pass the `validate_sending_time` setting from the session config to the parser. - Added new benchmark cases in `ExFixBench` to compare parsing performance with and without SendingTime validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new configuration option
validate_sending_timetoExFix.SessionConfig. When set tofalse, the validation of the SendingTime (tag 52) field in incoming messages will be skipped.This provides flexibility for scenarios where SendingTime accuracy is not critical or is handled by other systems, potentially improving message processing performance.
The following changes were made:
validate_sending_time(boolean, default: true) toExFix.SessionConfig.ExFix.Session.validate_sending_time/5to respect this new config.ExFix.Parser.parse1/5andExFix.Parser.parse/5to accept and pass down thevalidate_sending_timeparameter.ExFix.Session.handle_incoming_data/2to pass thevalidate_sending_timesetting from the session config to the parser.ExFixBenchto compare parsing performance with and without SendingTime validation.